MichaelRyanWebber
commented
8 months ago @hipstersmoothie Not sure how you'd actually want to solve this case, but figured I'd throw an attempt at it
could also do lte(next, currentVersion, true) here to get the "loose" checking, but I'd guess there would be issues later since "full" is the default.
the two regexes for reference:
full /^v?(0|[1-9]\d{0,256})\.(0|[1-9]\d{0,256})\.(0|[1-9]\d{0,256})(?:-((?:0|[1-9]\d{0,256}|\d{0,256}[a-zA-Z-][a-zA-Z0-9-]{0,250})(?:\.(?:0|[1-9]\d{0,256}|\d{0,256}[a-zA-Z-][a-zA-Z0-9-]{0,250}))*))?(?:\+([a-zA-Z0-9-]{1,250}(?:\.[a-zA-Z0-9-]{1,250})*))?$/
loose /^[v=\s]*(\d{1,256})\.(\d{1,256})\.(\d{1,256})(?:-?((?:\d{1,256}|\d{0,256}[a-zA-Z-][a-zA-Z0-9-]{0,250})(?:\.(?:\d{1,256}|\d{0,256}[a-zA-Z-][a-zA-Z0-9-]{0,250}))*))?(?:\+([a-zA-Z0-9-]{1,250}(?:\.[a-zA-Z0-9-]{1,250})*))?$/
hipstersmoothie
codecov[bot]
laughedelic
In the rare case that the first 7 characters of a git sha contains only numbers and begins with 0, SemVer will reject the canary (due to this part of the canaryIdentifier) as an invalid version.
In such cases, make sure we include enough of the sha to get a letter.
Ignore the ~1:1.5billion chance that SHA is all numbers starting with 0, but optionally the sha could be replaced with the string
jackpotTodo:
Change Type
Indicate the type of change your pull request is:
documentationpatchminormajor