intuit / cfn-deploy

A useful GitHub Action to help you deploy cloudformation templates
MIT License
15 stars 24 forks source link

Output example #27

Closed jgwinner closed 2 years ago

jgwinner commented 3 years ago

Hi

What outputs come out of this nice integration?

We need some of the created resource values.

For example - I have a CloudFormation stack that spins up a VM, attaches an RDS instance, and associates an Elastic IP to it (so the IP is persistent).

In this case, I need the output of the Elastic IP that's assigned - I wouldn't know this ahead of time - to be able to pass that to configuring an external DNS provider.

Can this integration help?

Thank you,

== John ==

mridhul commented 3 years ago

@jgwinner thanks for the note.

That's a nice feature to add. I'll add it to the todo and release it next month.

jgwinner commented 3 years ago

That sounds excellent, thank you.

== John ==

Malvikabhalla99 commented 3 years ago

I would like to take up this issue

jgwinner commented 3 years ago

Thanks for the assignment.

Do you need any help/testing/requirements?

mridhul commented 3 years ago

@jgwinner - this feature is implemened. Could you please share your feedback ? I'll keep it open till you confirm

jgwinner commented 3 years ago

That's great! Do you have an example of how to use them / syntax? Mixing CF and Actions YAML gets confusing.

jgwinner commented 3 years ago

Bump ^ Looking for syntax examples. I haven't switched over yet, will do soon.

jgwinner commented 3 years ago

I tried running the job, but got stuck at this point:

 + AWS_PROFILE=default
+ readonly DEFAULT_SLACK_WEBHOOK_URL=
+ DEFAULT_SLACK_WEBHOOK_URL=
+ readonly DEFAULT_GITHUB_JOB_LINK=https://github.com/intuit/cfn-deploy
+ DEFAULT_GITHUB_JOB_LINK=https://github.com/intuit/cfn-deploy
+ DEPLOYMENT_STATUS=IN_PROGRESS
+ [[ -z *** ]]
+ [[ -z *** ]]
+ [[ -z us-east-2 ]]
+ aws configure --profile default set aws_access_key_id ***
+ aws configure --profile default set aws_secret_access_key ***
+ aws configure --profile default set region us-east-2
/entrypoint.sh: line 181: NOTIFICATION_ARNS: unbound variable

We don't really need the NOTIFICATION_ARNS setup, as we have our own custom notification logic. I'll probably go back to a fork of the AWS project.

Hope that helps a little though.

== John ==