search

intuit / cfn-deploy

A useful GitHub Action to help you deploy cloudformation templates
MIT License
15 stars 24 forks source link

:bug: fix PARAMETERS_FILE unbound variable issue #28

Closed DinkuSarmah closed 3 years ago

DinkuSarmah commented 3 years ago

Some use cases do not require a PARAMETERS_FILE to be set.

mridhul commented 3 years ago

@DinkuSarmah could you please share a screenshot deploy happens with and without parameters file. Since we don't have unit testing, we have depended on screenshots as evidence. You can share the github actions links of your testing repo as well.

Trying to be doubly sure that we don't break any running deployments

DinkuSarmah commented 3 years ago

@mridhul

  1. Deployment with parameters file: image
  2. Deployment without parameters file: image
  3. AWS console screenshot of nested stack created without specifying parameters file: image

You can check build logs at https://github.com/DinkuSarmah/cfn-examples/actions