intuit / simple_deploy

Maintenance Mode - Simple Deploy is an opinionated CLI tool for managing AWS Cloud Formation Stacks.
MIT License
64 stars 22 forks source link

Added functionality to catch capistrano errors. Fixes issue 176. #198

Closed ccloes-intuit closed 11 years ago

ccloes-intuit commented 11 years ago

@brettweavnet ... @rickmendes ... This is for issue 176 https://github.com/intuit/simple_deploy/issues/176

This bubbles up the errors so that deployments fail to multiple stacks, but it currently fails the existing specs. I need to dig in and find out if I am breaking other funtionality or if the specs simply need to be updated.

We can chat about it tomorrow.

ccloes-intuit commented 11 years ago

@brettweavnet ... I updated the code per your suggestions and also updated the specs so that they succeed. I will take another look at them tomorrow morning to make sure I don't need to add any new tests.

weavenet commented 11 years ago

@ccloes-intuit looks good, I'd probably at one failing test for execute. Thanks