search

inukshuk / bibtex-ruby

A BibTeX library, parser, and converter for Ruby.
http://inukshuk.github.com/bibtex-ruby
GNU General Public License v3.0
155 stars 35 forks source link

feat: allows braces on citekey #151

Open mapreal19 opened 3 years ago

mapreal19 commented 3 years ago

@inukshuk this is what I attempted to fix #151 but is breaking other tests. This is the right direction?

mapreal19 commented 3 years ago

Travis not running tests? Shall we move it to Github Actions?

inukshuk commented 3 years ago

I was thinking to only change the lexer pattern for the parser to accept braces; we shouldn't strip them off the key, because it would be unexpected for the parser to alter the contents (this would have to go into some kind of optional filter, e.g., normalize_keys or something like that, but I don't think that it's necessary)

Yes, I think we're still configured for travis-ci.org which has been suspended and moving to Github Actions would be desirable. I'll open an issue for it.

mapreal19 commented 3 years ago

ok! I'll help with CI first

mapreal19 commented 3 years ago

@inukshuk you can see the failing tests. Any idea of why including the braces in the regex pattern is breaking those tests?

inukshuk commented 3 years ago

Hm, for some reason adding the braces seems to make the key pattern match even beyond the final comma -- it's not obvious on a quick glance why that would happen. I'll have to take a closer look.