inveniosoftware / domapping

Package generating elasticsearch mapping from jsonschemas
https://domapping.readthedocs.io
GNU General Public License v2.0
14 stars 8 forks source link

cli: addition of `mapping_type` parameter #10

Closed JavierDelgadoFernandez closed 8 years ago

JavierDelgadoFernandez commented 8 years ago

Signed-off-by: Javier Delgado javier.delgado.fernandez@cern.ch

JavierDelgadoFernandez commented 8 years ago

@nharraud Updated. Please, could you take a look when you have a minute?

JavierDelgadoFernandez commented 8 years ago

@nharraud Could you take a look please?

JavierDelgadoFernandez commented 8 years ago

This PR is ready from my side. Could someone take a look?

nharraud commented 8 years ago

@JavierDelgadoFernandez I just noticed the two little indentation issues. Other than that it looks good :) Good job! I'll merge the PR as soon as it's fixed.

JavierDelgadoFernandez commented 8 years ago

@nharraud Done ;)

jirikuncar commented 8 years ago

@JavierDelgadoFernandez please reformat the commit message (first line <=50 chars).