search

inveniosoftware / domapping

Package generating elasticsearch mapping from jsonschemas
https://domapping.readthedocs.io
GNU General Public License v2.0
14 stars 8 forks source link

mapping: enable to enabled #26

Closed jacquerie closed 7 years ago

jacquerie commented 7 years ago

The use of the _all field can be toggled with the enabled property, not enable. See: https://www.elastic.co/guide/en/elasticsearch/reference/2.4/mapping-all-field.html#disabling-all-field.

jacquerie commented 7 years ago

Failures seem unrelated... will send a PR for them.

jacquerie commented 7 years ago

Failures seem unrelated... will send a PR for them.

Done in #27.

nharraud commented 7 years ago

@jacquerie Thanks for spotting that! #27 is merged, could you please rebase?

jacquerie commented 7 years ago

could you please rebase?

Sure, done. Did closing and reopening #27 trigger another build, or did you have to do some manual work?

nharraud commented 7 years ago

@jacquerie In fact it was a mistake on my side. I had removed the webhook but not the required validation. Thanks for trying to close-reopen it.