inveniosoftware / helm-invenio

Helm charts for deploying an Invenio instance
https://helm-invenio.readthedocs.io
7 stars 20 forks source link

Enable using preexisting PVC #128

Closed lindhe closed 3 weeks ago

lindhe commented 1 month ago

Description

This change enables users to provide their own PVC for storing data, rather than forcing them to create a new one. This can be a handy way to decouple the lifecycle management of data from the app, for example to perform backup/restore operations.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.
lindhe commented 1 month ago

Normally I would recommend following a similar pattern as Bitnami do with existingClaim, especially for charts like this one that depends on Bitnami charts. But turns out that would introduce a lot of extra logic for us compared to this very minimal change, since we already have a name field for the PVC.

I'm pretty sure my current implementation is a non-breaking change.

Looking forward to your input on this!