search

inveniosoftware / invenio-previewer

Invenio module for previewing files.
https://invenio-previewer.readthedocs.io
MIT License
5 stars 60 forks source link

add lxml_html_clean now that it's broken off lxml #201

Closed fenekku closed 7 months ago

fenekku commented 7 months ago

lxml 5.2 took out into a separate distribution package (lxml-html-clean) code related to html cleaning. This caused nbconvert imports to break and so invenio_previewer/extensions/ipynb.py to break which then masked the error for subsequent preview calls.

I am placing the dependency on lxml_html_clean here since this is the trigger for the import problem. A backport should be done to maint-1.3 via cherry-pick when this is merged. (I can't merge on this repo, so backport better done by merger).

The solution for individual instances for now is to add lxml_html_clean to their Pipfile.

fenekku commented 7 months ago

@slint adjusted, ready for recheck.