search

inveniosoftware / rfcs

RFCs for Invenio.
https://rfcs.readthedocs.io
4 stars 15 forks source link

Installation and upgrade worflows for RDM #4

Closed ppanero closed 8 months ago

ppanero commented 5 years ago

@fenekku Thanks for the review! I fixed/reply to the comments. I also added one unnresolved question that could potentially affect your profiles/falvours RFC.

ppanero commented 5 years ago

Impotant note: No setup.py gets generated by the CLI, which means users will not have the option to extend/add entrypoints with custom development. Shall we allow that?

mb-wali commented 5 years ago

hello guys. i have tried the installation flow for invenio RDM. i dont understand why the invenio cli is out of the project directory. and using pip is not enough to complete the installation flow, its fine when we use the pipenv outside of the project directory but then we will have two pipfiles one inside the project directory and one outside where the invenio-cli is located. anyway.. it is a bit confusing but. the installation went alright.. also i was able to create the demo records. but when you want to see the specific records for example https://127.0.0.1:5000/records/5 there is an error:

UnboundLocalError
UnboundLocalError: local variable 'pid' referenced before assignment

.. thanks guys.. just wanted to give my update on the installation flow... Mojib from TUGRAZ.

lnielsen commented 5 years ago

@mb-wali Thanks a lot for the comments. Much appreciated.

1) why the invenio cli is out of the project directory

This will be fixed with the november release. I.e. it will be:

invenio-cli init
cd my-rdm
invenio-cli build

and NOT:

invenio-cli init
invenio-cli build

I.e. it will work much like npm and similar tools.

ppanero commented 4 years ago

Needs updating:

Possible more.