search

inveniosoftware / troubleshooting

DEPRECATED - Use the forum instead:
https://invenio-talk.web.cern.ch
5 stars 4 forks source link

isort 4.2.9 changed some sorting rules (errors on travis) #15

Open krzysztof opened 7 years ago

krzysztof commented 7 years ago

isort 4.2.9 introduced this change: https://github.com/timothycrosley/isort/issues/540 which might result in travis sorting error for some invenio modules such as:

ERROR: /home/travis/build/inveniosoftware/invenio-github/invenio_github/models.py Imports are incorrectly sorted.

To solve, just make sure to upgrade your local version and re-sort the imports.

krzysztof commented 7 years ago

This requires further attention since the -df (--diff) option by default does not modify the files, hence the -c flag in run_tests.sh is not only obsolete, but also when used in combination -df (as we have right now in every repo) the diff is not shown.

krzysztof commented 7 years ago

Another issue is that isort now complains about newline escape right after 'import'. I couldn't find an isort option to disable it:

-from zenodo.modules.records.serializers.pidrelations import \
-    serialize_related_identifiers
+from zenodo.modules.records.serializers.pidrelations import serialize_related_identifiers

This will produce cases where line length > 80 characters in many places

krzysztof commented 7 years ago

https://github.com/inveniosoftware/troubleshooting/issues/15#issuecomment-305772347

The issue with >80 chars and hanging import lines has been fixed in newest isort.