search

inventree / InvenTree

Open Source Inventory Management System
https://docs.inventree.org
MIT License
4.38k stars 791 forks source link

[Docker] Place translation stats file in external volume #5716

Open SchrodingersGat opened 1 year ago

SchrodingersGat commented 1 year ago 
          I see, that might explain why it is working over there.

Sounds logical to me to just expose the file to the data volume like the other precompiled assets... right?

Originally posted by @simonkuehling in https://github.com/inventree/InvenTree/issues/5214#issuecomment-1697426648

SchrodingersGat commented 1 year ago

See extended notes in #5214

SchrodingersGat commented 1 week ago

While reviewing this one I have discovered two things:

  1. The translation stats do not account for the react frontend translations
  2. The new "platform" frontend does not use the translation stats

@matmair @wolflu05 is this feature worth pursuing? Or should we eliminate it? I have a WIP to fix the above issues, but wondering if it is worth it

matmair commented 1 week ago

I found them handy in CUI but not sure if they are really worth it. Removing them would reduce complexity

SchrodingersGat commented 1 week ago

I'll leave the script in place (in case we need to use it again) but remove the integrations

SchrodingersGat commented 1 week ago

In fact, let's close this after we have removed CUI, as it will be pretty much useless after that

matmair commented 1 week ago

@SchrodingersGat I would prefer if we target this after 0.17.x to reduce possible issues

SchrodingersGat commented 1 week ago

Agreed