search

inverse-inc / packetfence

PacketFence is a fully supported, trusted, Free and Open Source network access control (NAC) solution. Boasting an impressive feature set including a captive-portal for registration and remediation, centralized wired and wireless management, powerful BYOD management options, 802.1X support, layer-2 isolation of problematic devices; PacketFence can be used to effectively secure networks small to very large heterogeneous networks.
https://packetfence.org
GNU General Public License v2.0
1.31k stars 278 forks source link

pfdhcp: a DHCPINFORM triggers a DHCPNAK which causes the client to lose its IP #3146

Closed julsemaan closed 6 years ago

julsemaan commented 6 years ago

If a client sends a DHCPINFORM, pfdhcp sends a NAK which causes the client to loses its IP address.

Reading through what a DHCPINFORM is used for, it seems we should probably just leave it unanswered

@fdurand can likely confirm

fdurand commented 6 years ago

It's suppose to return a DHCP Ack: http://www.ietf.org/rfc/rfc2131.txt or nothing. I prefer the ack because we can return additional options.

julsemaan commented 6 years ago

It seems that if we don't send an ACK then that may delay the initialization of the client so lets send an ACK