search

invertase / react-native-apple-authentication

A React Native library providing support for Apple Authentication on iOS and Android.
Other
1.4k stars 223 forks source link

Usage with RN Web #342

Closed gavrilikhin-d closed 7 months ago

gavrilikhin-d commented 7 months ago

Is this possible to use this library with RN Web?

Currently, there is an error:

ERROR in ./node_modules/@invertase/react-native-apple-authentication/lib/index.js 24:0-55
Module not found: Error: Can't resolve './AppleButton' in 
'/Users/gavrilikhin_d/Code/chatroulette/app/mobile/node_modules/@invertase/react-native-apple-authentication/lib'
mikehardy commented 7 months ago

335 needs testing. If working on the web is important please pull that PR (perhaps rebase it to current main...) and test it, report findings

gavrilikhin-d commented 7 months ago

There is still no AppleButton.web.js in this PR

mikehardy commented 7 months ago

@gavrilikhin-d okay, then perhaps that PR needs additional work - if you have the PR pulled locally and web implementation is important, adding additional commits on the original PR and proposing a new + augmented PR could be the way forward

gavrilikhin-d commented 7 months ago

I will try to make it work with your library, once I will fix the rest of the RN-web issues in our project XD

On Fri, Feb 9, 2024, 15:49 Mike Hardy @.***> wrote:

@gavrilikhin-d https://github.com/gavrilikhin-d okay, then perhaps that PR needs additional work - if you have the PR pulled locally and web implementation is important, adding additional commits on the original PR and proposing a new + augmented PR could be the way forward

— Reply to this email directly, view it on GitHub https://github.com/invertase/react-native-apple-authentication/issues/342#issuecomment-1935873433, or unsubscribe https://github.com/notifications/unsubscribe-auth/AR5SO7QDIDGTCL6UJQYV3G3YSYLPNAVCNFSM6AAAAABC7V7DW2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZVHA3TGNBTGM . You are receiving this because you were mentioned.Message ID: @.*** com>