search

invertedtomato / packing

Library for encoding integers in the minimal number of bits. Includes VLQ and Elias Omega encoding.
MIT License
76 stars 6 forks source link

Would you accept patch migrating to .NET Core? #4

Closed dzmitry-lahoda closed 5 years ago

dzmitry-lahoda commented 5 years ago

Works on Linux/Mac/Arm:

dotnet build
dotnet pack -c Release
dotnet test
dotnet run -c Release

Will port performance into https://github.com/dotnet/BenchmarkDotNet either. And target .NET Standard 2.0.

dzmitry-lahoda commented 5 years ago

I see library updated, but not tests-samples. So only tests and samples than.

dzmitry-lahoda commented 5 years ago

dotnet build fails out of box

's faster!' [F:\src\dotnet\integer-compression\Test\Test.csproj]
Compression\Integers\Wave2\VLQCodecTests.cs(196,17): warning CS0618: 'VLQCodec' is obsolete: 'Consider using InvertedTomato.Compression.Integers.Wave3.VlqCodec instead. It's faster!' [F:\src\dotnet\integer-compression\Test\Test.csproj]
Program.cs(4,22): error CS0234: The type or namespace name 'IO' does not exist in the namespace 'InvertedTomato' (are you missing an assembly reference?) [F:\src\dotnet\integer-compression\Benchmark\Benchmark.csproj]
    39 Warning(s)
    1 Error(s)

Time Elapsed 00:00:19.25
invertedtomato commented 5 years ago

Looks like you're missing a .NET restore. Is that right?

Why migrate to .NET Core? .NET Standard can be used in all scenarios Core can, as well as others.

dzmitry-lahoda commented 5 years ago

yep. .NET Standard. So

git clone
dotnet restore
dotnet build
dotnet test

would work given installed SDK.