search

invoiceninja / dockerfiles

Docker files for Invoice Ninja
https://hub.docker.com/r/invoiceninja/invoiceninja
GNU General Public License v2.0
398 stars 264 forks source link

Recent docker builds are failing due to composer.lock changes #520

Closed anojht closed 1 year ago

anojht commented 1 year ago

I am going to keep this brief as you can already see the docker build failure logs in your Github Actions pipeline.

The following commit which introduced large dependency bumps in the composer.lock file has caused release builds to fail since the commit was introduced: commit SHA

If I revert the composer.lock file to 1 commit before the problematic one, the build works fine. I just pushed a v5.6.10 image for a docker container that I maintain myself for invoiceninja with this manual change.

I wanted to report it here and tag @turbo124 @lalop in case it helps your troubleshooting.

turbo124 commented 1 year ago

I attempted to revert the lock file but I'm still seeing issues.

I'm looking into an appropriate fix for this, thanks for reporting. @anojht

anojht commented 1 year ago

I added the following line: RUN curl -L https://raw.githubusercontent.com/turbo124/invoiceninja/b71e3a19af5c628850a0e7f284d279cc7e5f4d33/composer.lock -o composer.lock above the RUN /usr/local/bin/composer install --no-dev --quiet line.

It's very crude but it basically fetches the working version of the composer.lock file and overwrites the one in the directory before installing dependencies. Seems to fix builds for me.

I unfortunately don't have the expertise when it comes to PHP to narrow down which dependency(s) are the problematic ones. I am a TS/C# guy... 😅

anojht commented 1 year ago

Looks like the latest changes fixed the build.

Thanks and great job tracking down the fix! 😄
Closing this issue now.