search

invoiceninja / sdk-php

PHP wrapper for Invoice Ninja's REST API
https://www.invoiceninja.com
83 stars 42 forks source link

Shouldn’t disable SSL verification by default #75

Closed minorOffense closed 2 years ago

minorOffense commented 2 years ago

The SDK’s default http client disables SSL verification and that’s probably not a good idea.

I’d suggest removing that setting. If you need to toggle it off (e.g. for tests or local dev) add a flag in the constructor or a debug mode env var.

https://github.com/invoiceninja/sdk-php/blob/7a644a50be2b5d24863cc03b01cdf84f62011d6d/src/InvoiceNinja.php#L174

turbo124 commented 2 years ago

Thanks

78