search

ioam / topographica

A general-purpose neural simulator focusing on topographic maps.
topographica.org
BSD 3-Clause "New" or "Revised" License
53 stars 32 forks source link

Plot history length control #505

Closed mjabri closed 11 years ago

mjabri commented 11 years ago

Added history length to the Plot Panel GUI. The length control is tested using: from topo.tkgui.plotgrouppanel import PlotGroupPanel PlotGroupPanel.maximum_plot_history_length =xxx where xxx above was tried with -1, 0, and various > 0 values. Note the parameter above is documented in the code.

jbednar commented 11 years ago

Thanks! That looks very reasonable. However, a couple of things need fixing before the request can be merged:

First, each unrelated feature should be added in a separate pull request, so that they can each be applied independently. I've now checked in your STDERR change separately, along with a fix for running Topographica outside the main topographica directory, so that file should be deleted from this particular pull request.

Also, ALERTs are for problems with the code or things we think might be dangerous, not just for changes that you've made. Actually, please don't add any comments for changes, because we can clearly see the changes in the diff already. Instead, just make the change, and then describe it in the pull request if necessary. So those comments should be deleted from the code before the pull request can be merged.

Otherwise, looks good, and I'll be happy to apply it!

jbednar commented 11 years ago

Looks great, thanks!