ioccc-src / mkiocccentry

Form an IOCCC submission as a compressed tarball file
Other
30 stars 6 forks source link

Add missing calls to errp() in txzchk #1203

Closed xexyl closed 1 month ago

xexyl commented 1 month ago

This might be important in some cases as we're now at the point of the next contest. The calls are specific to the functions popen(3) in pipe_open() and system(3) in shell_cmd(). In linux in some cases popen() will set errno; in macOS it is unreliable. For system(3) it appears that errno is not set so warnp()/errp() were changed to the non-errno versions.

Updated TXZCHK_VERSION to "2.0.1 2025-03-02".

xexyl commented 1 month ago

Hold on. I forgot to do jparse updates first ... to save errno.

lcn2 commented 1 month ago

Hold on. I forgot to do jparse updates first ... to save errno.

No worries, we will wait.

xexyl commented 1 month ago

Just pushed the change ... though I did not use make release. However since it does it here it will let me know. If I need to I will run it locally and fix.

I'll reply to your other comment now and then hope to get to the guidelines.

lcn2 commented 1 month ago

We are propagating this version of the tool set now.

xexyl commented 1 month ago

We are propagating this version of the tool set now.

Sounds good. I'd guess in most cases it's not necessary but in those cases where it might be useful it'd be good to have.

lcn2 commented 1 month ago

Correction .. make release sequenced exit codes

UPDATE 0

Updating from clone seems to be OK.

xexyl commented 1 month ago

Correction .. make release sequenced exit codes

Oh I always forget that one. Since it is also possibly in jparse I'll make sure of that, commit if necessary and then do it here too. Hold please.

xexyl commented 1 month ago

Done with the first part .. will commit shortly.

The reason this happens is I just put a number (usually 55 for some reason) in calls and then I normally will sequence them when I'm done as it's easier that way. But sometime (not always as above but more than once or twice it has happened) I do forget. Anyway almost there.

xexyl commented 1 month ago

Done.

lcn2 commented 1 month ago

Doing a:

make all.update_clone
make all.update_from_clone

shows:

$ git status
On branch master
Your branch is up to date with 'origin/master'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
    modified:   jparse/util.c
lcn2 commented 1 month ago

Trying this now:

make all.update_clone  ; make all.update_from_clone ; make release ; git status

produces:

Your branch is up to date with 'origin/master'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
    modified:   jparse/util.c

no changes added to commit (use "git add" and/or "git commit -a")
xexyl commented 1 month ago

Trying this now:

make all.update_clone  ; make all.update_from_clone ; make release ; git status

produces:

Your branch is up to date with 'origin/master'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
  modified:   jparse/util.c

no changes added to commit (use "git add" and/or "git commit -a")

Great! Thanks for the reminder.

lcn2 commented 1 month ago

Things look clean .. propagating the install now ... stay tuned ...

UPDATE 0a

.. fending off (system successfully repelled) system crackers .. one moment while we address this ... done

Now back to propagation of the install ... stay tuned ... installed.

UPDATE 1a

git tagging the release ... stay tuned ... tagging complete .. now ...

...
No local changes to save
From github.com:ioccc-src/mkiocccentry
 * [new tag]           2.4.2      -> 2.4.2
Already up to date.

UPDATE 2

Creating the release ... stay tuned ...

UPDATE 3

Released version 2.4.2 2025-03-02.

All Done!!! All Done!!! -- Jessica Noll, Age 2

xexyl commented 1 month ago

Things look clean .. propagating the install now ... stay tuned ...

UPDATE 0a

.. fending off (system successfully repelled) system crackers .. one moment while we address this ... done

Now back to propagation of the install ... stay tuned ... installed.

UPDATE 1a

git tagging the release ... stay tuned ... tagging complete .. now ...

...
No local changes to save
From github.com:ioccc-src/mkiocccentry
 * [new tag]           2.4.2      -> 2.4.2
Already up to date.

UPDATE 2

Creating the release ... stay tuned ...

UPDATE 3

Released version 2.4.2 2025-03-02.

All Done!!! All Done!!! -- Jessica Noll, Age 2

As I noted in the OT thread I don't get this in my fork even after a pull. Strange. The non-fork clone does work fine. But fork has no tag. I'll see if I can cause it to sync up here on GitHub.

xexyl commented 1 month ago

Things look clean .. propagating the install now ... stay tuned ...

UPDATE 0a

.. fending off (system successfully repelled) system crackers .. one moment while we address this ... done Now back to propagation of the install ... stay tuned ... installed.

UPDATE 1a

git tagging the release ... stay tuned ... tagging complete .. now ...

...
No local changes to save
From github.com:ioccc-src/mkiocccentry
 * [new tag]           2.4.2      -> 2.4.2
Already up to date.

UPDATE 2

Creating the release ... stay tuned ...

UPDATE 3

Released version 2.4.2 2025-03-02.

All Done!!! All Done!!! -- Jessica Noll, Age 2

As I noted in the OT thread I don't get this in my fork even after a pull. Strange. The non-fork clone does work fine. But fork has no tag. I'll see if I can cause it to sync up here on GitHub.

GitHub also claims it's up to date ... strange.

lcn2 commented 1 month ago

GitHub also claims it's up to date ... strange.

See a comment a few days ago about tags being meta data and not a change to content.