search

ioccc-src / mkiocccentry

Form an IOCCC submission as a compressed tarball file
Other
30 stars 6 forks source link

Enhancement: mkiocccentry does not ignore dirrectories such as SCCS #1207

Open SirWumpus opened 1 month ago

SirWumpus commented 1 month ago

Is there an existing issue for this?

Describe the bug

In the list of ignored directories related to version control, SCCS has been overlooked.

We ignore certain directory names, in particular:

              .bzr       .circleci       .fslckout
              .git         .github         .gitlab
               .hg           .idea            .svn
         BitKeeper             CVS            RCS
          _FOSSIL_            _MTN          _darcs

This is so that one may use an RCS without having to worry about
copying everything to another directory simply to use this tool.

What you expect

Ignore SCCS directories. Also as I recall RCS ci(1) and co(1) used an RCS directory.

Environment

bug_report.sh output

No response

Anything else?

No response

xexyl commented 1 month ago

Thanks for the suggestion! Good call.

Would you please assign this to me @lcn2 ? I can take care of it tomorrow. I actually also implemented the uuid file option to make it much quicker to use.

But I can talk about that later.

Have to go again.

Thanks @SirWumpus for the suggestion!

xexyl commented 1 month ago

To help out @SirWumpus: please give a precise list of directory names.

If you did then please just confirm (I am rushed and I also am reading this with my phone and distance glasses). Thanks!

lcn2 commented 1 month ago

If this is addressed before IOCCC28 "closes" (and that is a big IF), then the Important NOTE from issue 1209 needs to be considered.

lcn2 commented 1 month ago

We have relabeled this a feature. The stuff such as .idea are ignored by mkiocccentry(1) by default.

Things such as SCCS (that is probably what RCCS means in the top level comment) or CVS less likely to be used and so les likely to be a problem. Even if, say CVS or BitKeeper were found ANY the a rule violation were not triggered (say because there wasn't enough "extra" files to go over the limit), then the IOCCC judges can simply ignore such content.

xexyl commented 1 month ago

I'll quickly add this to the soup file ... thanks @SirWumpus!

xexyl commented 1 month ago

I added both directory names to this btw. So when I do the commit this will be resolved.

SirWumpus commented 1 month ago

I added both directory names to this btw. So when I do the commit this will be resolved. These two right?

SCCS
RCS
xexyl commented 1 month ago

I added both directory names to this btw. So when I do the commit this will be resolved. These two right?

SCCS
RCS

Thanks for confirming. I did this. I was able to tell with both reading glasses (as opposed to distance) and being more awake.

This was done a bit ago - working on the other issue(s). When those are done I'll do a commit and this will be resolved. Nice catch! Thanks again!

xexyl commented 1 month ago

Unless I am very much mistaken, @SirWumpus, commit https://github.com/ioccc-src/mkiocccentry/pull/1211/commits/7c1bc2ea72d46d617e04e823736336616739650e should resolve this issue.

Please let me know when you get a chance.

lcn2 commented 1 month ago

BTW: Resolving this issue is pending the successful resolution and extended testing of the resolution of issue #1215.

lcn2 commented 1 month ago

We believe we have addressed all of the current questions that still need answering at this time. If we've missed something or something else needs to be clarified, please ask again.

xexyl commented 1 month ago

BTW: This commit is pending the successful resolution and extended testing of the resolution of issue #1215.

Yup. As I noted 'over there' I am fixing it now. I got verge.o into the library so I have to update the functions now - and add a#include "../jparse/verge.h" of course. Once all that is done I can commit to jparse too.

lcn2 commented 1 month ago

While we are not opposed to issue #1207, ignoring SCCS or RCS is hardly a reason for an emergency fix while IOCCC28 is open.

Moreover, what IF there a submission to IOCCC28 already that is an obfuscated rcs tool? How would such a submitter update such a submission if mkiocccentry(1) were to suddenly change out from under them if, as part of their submission, they had a RCS directory?

While issue #1207 should NOT be added to the mkiocccenty tool set whole IOCCC28 is open. Issue #1207 should be added before IOCCC29 opens, along with suitable changes to the guidelines AND FAQs about what is ignored by mkiocccenry(1).

xexyl commented 1 month ago

While we are not opposed to issue #1207, ignoring SCCS or RCS is hardly a reason for an emergency fix while IOCCC28 is open.

Moreover, what IF there a submission to IOCCC28 already that is an obfuscated rcs tool? How would such a submitter update such a submission if mkiocccentry(1) were to suddenly change out from under them if, as part of their submission, they had a RCS directory?

While issue #1207 should NOT be added to the mkiocccenty tool set whole IOCCC28 is open. Issue #1207 should be added before IOCCC29 opens, along with suitable changes to the guidelines AND FAQs about what is ignored by mkiocccenry(1).

Yes it must come after.

That is why I rolled it back. I did not think of that until earlier this morning.

xexyl commented 1 month ago

It is important to note that although the min version change is useful it cannot prevent all problems. For instance this issue cannot be resolved by it as the way the checks are done is in a list and function that checks that list - chkentry would flag a submission if these files existed.

lcn2 commented 1 month ago

We believe we have addressed all of the current questions that still need answering at this time. If we've missed something or something else needs to be clarified, please ask again.

lcn2 commented 3 weeks ago

Important checkpoint

Please see GH-issuecomment-2762004417 for a recent comment on existing issues, priorities, and on a deadline for going into pending state for IOCCC29.