iodide-project / iodide

Literate scientific computing and communication for the web
Mozilla Public License 2.0
1.49k stars 142 forks source link

as a user, I want to be able to do some basic styling on the body element of the report #1000

Open hamilton opened 5 years ago

hamilton commented 5 years ago

example notebook that demonstates the issue. To summarize:

hamilton commented 5 years ago

This is higher priority than p3, I think. One way in which iodide will "break" for users if we change this after we tag a release as an MVP is that the CSS will change, so any workarounds or methods they used to create a document will simply not work. Seems like we should have a plan around this, though perhaps not immediately.

bcolloran commented 5 years ago

"should have a plan around this, though perhaps not immediately" sounds like a pretty good definition of p3 to me :-)

MVP functionality need not include supporting advanced css styling at all -- for the MVP, if users can eval code and use MD, we're at parity with Jupyter; something like that is "minimum", and there is much higher priority core workflow stuff still to tackle. advanced styling will be important, but is not doing it perfectly is not core to our initial offering

hamilton commented 5 years ago

I agree that the default report view is not "broken", but css is generally broken in the eval frame right now, and badly enough that we ought to just disallow any styling if we're not going to have a plan before MVP. I can't speak for everyone, but this has been a major rough edge with using Iodide for a large class of real work (dashboarding, actual reports) for me already. Parity w/ Jupyter in this feature doesn't feel like enough here, given my own experience working w/ the DOM in iodide. "changing the font" doesn't feel advanced to me, but it is genuinely difficult, and could be made easier.

bcolloran commented 5 years ago

@hamilton has proposed an idea about using shadowDOM for the implementation of this. @hamilton please feel free to add any additional details along those lines.