search

ioerror / torbirdy

Torbutton for Thunderbird and related *bird forks
BSD 2-Clause "Simplified" License
84 stars 20 forks source link

Make extensions.torbirdy.defaultprotocol affect the autoconfiguration wizard #31

Closed u451f closed 8 years ago

u451f commented 8 years ago

This is a fixup on Fred A. Kemp's previous patches: it makes the existing extensions.torbirdy.defaultprotocol preference have the intended effect when the autoconfiguration wizard is used. Otherwise it only affects the non-auto wizard.

azadi commented 8 years ago

I haven't looked at the gEmailConfigWizard code in detail so before I merge this, is my understanding correct that the difference between https://gitweb.torproject.org/torbirdy.git/commit/?id=602b5d8f7d342ec86f3494791e65ecc5bfd097a6 and this pull request is the timing and the fact that the selection is enforced?

anonym commented 8 years ago

Hi!

[...] is my understanding correct that the difference between https://gitweb.torproject.org/torbirdy.git/commit/?id=602b5d8f7d342ec86f3494791e65ecc5bfd097a6 and this pull request is the timing [...]

While the timing is different, this is not the point. Notice the XUL id's of what commit 602b5d8 (well, actually the line of code under the change) vs my patch alters. The menulist with id torbirdy-protocol is not used in the auto wizard but only in TorBirdy's replacement wizard, so I instead mess with the ~corresponding elements, result_imappop and incoming_protocol. Note that they are not used at all in TorBirdy's replacement wizard.

[...] and the fact that the selection is enforced?

I'm not exactly sure what you mean. The intention (and effect, according to my testing) of my patch is only to alter the default selections of these to elements, and allow the user to pick the other one if they so prefer. If this doesn't answer you're question, please clarify!

u451f commented 8 years ago

thanks <3