purplesyringa commented 4 years ago

Closes #56.

ionelmc commented 4 years ago

Can you also update the tests?

purplesyringa commented 4 years ago

Will do.

codecov-io commented 4 years ago

Codecov Report

Merging #57 into master will increase coverage by 0.04%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
+ Coverage   89.38%   89.43%   +0.04%     
==========================================
  Files           4        4              
  Lines         245      246       +1     
  Branches       42       42              
==========================================
+ Hits          219      220       +1     
  Misses         16       16              
  Partials       10       10

Impacted Files	Coverage Δ
src/tblib/__init__.py	`91.4% <100%> (+0.06%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update aaf6199...21c258c. Read the comment docs.

purplesyringa commented 4 years ago

I can't run the tests locally (unfortunately) so I have to use Travis CI. I'll send a comment when I get the tests passing.

purplesyringa commented 4 years ago

The tests are passing now. @ionelmc

purplesyringa commented 4 years ago

@ionelmc Do you think the PR looks good?

ionelmc commented 4 years ago

Looks good. Can you also update changelog/authors with what you like?

Also, correct to assume you'd follow up this with a gevent PR or something? CC @jamadden

purplesyringa commented 4 years ago

Can you also update changelog/authors with what you like?

Done, please check that I've done it correctly.

Also, correct to assume you'd follow up this with a gevent PR or something?

True. I want to get #58 merged before though.

purplesyringa commented 4 years ago

Merging into #58.

ionelmc / python-tblib

Add Frame.f_lineno #57

Codecov Report