ionic-team / ionic-docs

https://ionicframework.com/docs
Apache License 2.0
590 stars 3.03k forks source link

bug: Icon is not working for action sheet button #3855

Open johngeng opened 1 month ago

johngeng commented 1 month ago

Describe the Bug

When specify icon to ActionSheetButton, the icon is not rendered. Here is link to reproduce https://stackblitz.com/edit/tcrhwk?file=src%2Fmain.tsx

`import React from 'react'; import { IonActionSheet, IonButton } from '@ionic/react';

function Example() { return ( <>

Open
  <IonActionSheet
    trigger="open-action-sheet"
    header="Actions"
    buttons={[
      {
        text: 'Delete',
        role: 'destructive',
        icon: 'close',
        data: {
          action: 'delete',
        },
      },
      {
        text: 'Share',
        icon: 'arrow-redo',
        data: {
          action: 'share',
        },
      },
      {
        text: 'Cancel',
        role: 'cancel',
        data: {
          action: 'cancel',
        },
      },
    ]}
  ></IonActionSheet>
</>

); } export default Example;`

Expected Behavior

Should show close icon for action delete button, and arrow-redo icon for action share button

Steps to Reproduce

Run the link https://stackblitz.com/edit/tcrhwk?file=src%2Fmain.tsx

Screenshots

No response

Operating System

Windows

Browser

Chrome

Version

129

Additional Information

No response

johngeng commented 1 month ago

@sean-perkins any comment please?