search

ionic-team / ionic-framework

A powerful cross-platform UI toolkit for building native-quality iOS, Android, and Progressive Web Apps with HTML, CSS, and JavaScript.
https://ionicframework.com
MIT License
50.94k stars 13.52k forks source link

bug: V 1.2 Slider with images overlays everything else? #4802

Closed uofmmike closed 8 years ago

uofmmike commented 8 years ago

Type: bug

Platform: all

Slider in ionic#v1.2.0-nightly-1839 appears to not overlay correctly.

Issue seen here: http://codepen.io/uofmmike/pen/pggqbB

(and inline here)

<html ng-app="ionicApp">

<head>
  <meta charset="utf-8">
  <meta name="viewport" content="initial-scale=1, maximum-scale=1, user-scalable=no, width=device-width">

  <title>Ionic Custom Loading Bar</title>

  <link href="//code.ionicframework.com/nightly/css/ionic.css" rel="stylesheet">
  <script src="//code.ionicframework.com/nightly/js/ionic.bundle.js"></script>

</head>

<body ng-controller="MainCtrl">

  <ion-view view-title="Dashboard">
    <ion-content class="padding">
      <div class=" card">
        <h4>Layered behind :(</h4>
      </div>
      <div class='card'>
        <ion-slides options="">
          <ion-slide-page>
            <img src='https://upload.wikimedia.org/wikipedia/commons/thumb/6/6e/Golde33443.jpg/398px-Golde33443.jpg'>
          </ion-slide-page>
          <ion-slide-page>
            <img src='https://upload.wikimedia.org/wikipedia/commons/thumb/6/6e/Golde33443.jpg/398px-Golde33443.jpg'>
          </ion-slide-page>
        </ion-slides>
      </div>
    </ion-content>
  </ion-view>

</body>

</html>

```</span>

<span is-issue-template></span>
mlynch commented 8 years ago

Should be fixed in master and will be in 1.2.1 this week. Mind letting me know how that works?

uofmmike commented 8 years ago

Thanks for the reply @mlynch!

Don't know if i've got a config wrong, now, i'm not seeing anything in the pen I provided earlier.

I replaced the images and followed the docs at :http://ionicframework.com/docs/nightly/api/directive/ionSlides/

Now I'm not seeing anything from the slider? http://codepen.io/uofmmike/pen/pggqbB

uofmmike commented 8 years ago

Looks like it's an issue within the card, outside of the card the slider is fine, inside there appears to be no height. I'll create a separate issue for a new patch.

4881 Linked issue