chore: upgrade to stencil 3

ionic-team / pwa-elements

Quality UI experiences for Web APIs that require custom UI (such as media/camera).

https://medium.com/@maxlynch/building-the-progressive-web-app-os-57daebcb69c1

MIT License

168 stars 50 forks source link

chore: upgrade to stencil 3 #118

Closed sean-perkins closed 1 year ago

sean-perkins commented 1 year ago

Upgrades the Stencil project to v3, resolving the problem with consuming in a Vite project.

Resolves #109

This PR is in favor of #107.

sean-perkins commented 1 year ago

@liamdebeasi are you wanting to test it against the Ionic React vite blank project for example? We don't have dev-builds configured for this repo, so we'd need to locally build/pack and install it into a consuming project.

liamdebeasi commented 1 year ago

Yeah I wasn't sure if there was a sample app that the original bug was tested in? I could build the project and install it there to verify.

sean-perkins commented 1 year ago

@liamdebeasi I checked against the reproduction provided in: https://github.com/ionic-team/pwa-elements/issues/109 and everything is working as expected 👍