search

ionic-team / pwa-elements

Quality UI experiences for Web APIs that require custom UI (such as media/camera).
https://medium.com/@maxlynch/building-the-progressive-web-app-os-57daebcb69c1
MIT License
168 stars 50 forks source link

Warning when running with Angular + Vite #129

Open elongberg opened 10 months ago

elongberg commented 10 months ago

Running a fresh Angular 17 project, which uses Vite, and latest Capacitor. Added pwa-elements as described in the Capacitor docs https://capacitorjs.com/docs/web/pwa-elements#angular: main.ts:

import { defineCustomElements } from '@ionic/pwa-elements/loader';
defineCustomElements(window);

Running the code (ng serve) results in this warning: "The above dynamic import cannot be analyzed by Vite". image

Notably, everything does still seem to function, but the warning is a nuisance.

Hard to say if the issue is more with the stencil version that builds pwa-elements or what.

Workarounds Changing the vite config as described here https://github.com/ionic-team/pwa-elements/issues/109#issuecomment-1405061645 might potentially work, except Angular doesn't currently support configuring vite (https://angular.io/guide/esbuild#:~:text=currently%20cannot%20be%20directly%20configured).

Instead including pwa-elements via a cdn script tag in index.html does remove the warning, but doesn't work for offline scenarios.

felixgeissler commented 1 month ago

@sean-perkins I can confirm that this warning still persists with @ionic/pwa-elements 3.3.0