ionic-team / stencil-ds-output-targets

These are output targets that can be added to Stencil for React and Angular.
https://stenciljs.com
MIT License
250 stars 118 forks source link

fix(react): enable event names with forward slash #474

Closed alexprudhomme closed 2 months ago

alexprudhomme commented 2 months ago

fix #473

Pull request checklist

Please check if your PR fulfills the following requirements:

Pull request type

Please check the type of change your PR introduces:

What is the current behavior?

Issue URL:

What is the new behavior?

Does this introduce a breaking change?

Other information

alexprudhomme commented 2 months ago

@alexprudhomme I tested this out with your / event naming, but doesn't seem to work with that convention. As far as I know, React requires strict camel-casing for event handlers, so if you wanted to have event names with a / in them, you would need to update the logic here to also perform those replacements

Hey, @tanner-reits thanks for the useful tip. I changed the implementation and added a test. Let me know if you need anything more.

alexprudhomme commented 1 month ago

@tanner-reits Hi, Will you be able to make a release soon with this fix ? Last one was on august 28th. Thanks !

christian-bromann commented 1 month ago

@alexprudhomme I am working on it as we speak.