ionic-team / stencil-ds-output-targets

These are output targets that can be added to Stencil for React and Angular.
https://stenciljs.com
MIT License
250 stars 118 forks source link

chore: restructure packages #493

Closed christian-bromann closed 1 month ago

christian-bromann commented 1 month ago

Pull request checklist

Please check if your PR fulfills the following requirements:

Pull request type

Please check the type of change your PR introduces:

What is the current behavior?

It is a bit confusing to have the example project next to our output target packages.

What is the new behavior?

A little restructuring to make the responsibilities more clear:

Screenshot 2024-10-09 at 3 44 45 PM

Does this introduce a breaking change?

Other information

n/a

christian-bromann commented 1 month ago

It seems that the Next.js tests are failing which may be related to a recent WebdriverIO update, I am investigating this. Regardless please provide feedback if you support the idea of this restructure.

thetaPC commented 1 month ago

I have no issues with this reorganization. Ping me once the checks are passing.

christian-bromann commented 1 month ago

pnpm run build doesn't build the Next app (due to script naming)

I've updated the script to include building the Next.js application as part of the main build.

Should this still exist? Don't think it's serving a purpose here

The error is a result of a React type mismatch between the React version from the @lit/react project and the version used in the Next.js app. I tried to enhance. the Options type with another generic to pass the original React type along, unfortunately I wasn't successful. I ended up just adding a ts-ignore on top of the line. This should be sufficient as I don't expect a scenario where the React version mismatch impacts how the component is being rendered as we pass along the right React object, it is just the type that is not passed along.

christian-bromann commented 1 month ago

I will move ahead and merge this as I realised when merging the upstream PRs that the changeset now has become to large. Happy to address any further concerns in a separate PR.