Fix #9: Choose project based on active file

[MangelMaxime]

Careful, don't release this until we fixed #15 or we need a manual action on release.

[MangelMaxime]

Don't merge this PR yet, I should filter current file type.

• If the file end with .fsproj use it directly
• If the file end with .fs try to find the associated project
• For others, will go for the default way

[forki]

@Krzysztof-Cieslak when this is ready - please release ;-) I'm away from PC now

[MangelMaxime]

Should be ready for review.

@forki Perhaps, you could give us the action needed to release a new version to avoid deploying a broken version of mech.dll

[forki]

Ah good point. Easiest fix. Change the build script here to run dotnet publish in the src folder of mechanic.commandline. Just right before that line that copies the mech libs. And instead of copying them from debug folder, copy them from the /public folder within that debug folder. Or even better: do the above but for release mode.

Maxime Mangel notifications@github.com schrieb am Di., 13. März 2018, 17:50:

Should be ready for review.

@forki https://github.com/forki Perhaps, you could give us the action needed to release a new version to avoid deploying a broken version of mech.dll

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ionide/ionide-vscode-mechanic/pull/16#issuecomment-372736676, or mute the thread https://github.com/notifications/unsubscribe-auth/AADgNEMdk4XIOxSBYoiDQ6ZaM-asLtauks5td_jpgaJpZM4So84x .

[MangelMaxime]

I sent a PR https://github.com/fsprojects/Mechanic/pull/86

[forki]

Even better

[forki]

is this ready?

[MangelMaxime]

Yes, it's ready for review and test.

[forki]

I think we broke something

tried on mechanic itself:

[MangelMaxime]

Was the project loaded ? Does the file belongs to an fsproj ?

[MangelMaxime]

Seems like we were in this case:

https://github.com/ionide/ionide-vscode-mechanic/blob/98c8d1ad5c9b8548df1dfcc18321e0399251ccab/src/Mechanic.fs#L49-L54

In this case we probably need to execute:

https://github.com/ionide/ionide-vscode-mechanic/blob/98c8d1ad5c9b8548df1dfcc18321e0399251ccab/src/Mechanic.fs#L64-L85

[forki]

PR appreciated ;-)

[MangelMaxime]

Hum...

If the file is not associated to project file then running Mechanic is useless. We probably need to add the file to an fsproj first.

What do you think ?

[forki]

it is in the project.

The filter |> List.contains textEditor.document.uri.path dosesn't work.

I'm debugging it

[forki]

Ok I listed the files in the project and then the textEditor.document.uri.path:

obviously they are in different format. similar issue to https://github.com/ionide/ionide-vscode-mechanic/issues/18

do we already have a way to normilze that? /cc @Krzysztof-Cieslak

[forki]

how do we know if we are on windows or linux?

[MangelMaxime]

@forki Ah yes logic...

We can normalize the path: https://nodejs.org/api/path.html#path_path_normalize_path We can detect the OS:

open Fable.Import

if Node.Exports.os.platform() = Node.Base.NodeJS.Win32 then
    // We are under windows

[Krzysztof-Cieslak]

I think document.filename or document.uri.fsPath should have correct, normalized paths (from top of my head)

[MangelMaxime]

@forki Can I let you check that ? I don't have access to a Windows computer

[forki]

current solution works for me. maybe we should just keep it