Closed manishiitg closed 3 years ago
I think it's a bad idea to commit so many large movie files to this repo. Please find a way to make this PR not include large, unnecessary video files, it will greatly increase the library size; alternatively, since this is just an "example", you could move the code and all the videos to an unrelated repository.
PLEASE NOTE - ADDING A NEW COMMIT THAT REMOVES THE FILES IS INSUFFICIENT. Adding a "remove these files" commit will leave the large files in the git history. Please ensure you fully remove the files from the history.
Thanks for your interest in helping with ion-sdk-go
! I don't mean to be harsh but - In general, this PR adds a lot of small changes that I think would be better if you split up into smaller PRs that were more related - like changing log.Error
to log.Debug
without a good explanation/justification. Maybe those kinds of changes are appropriate, but they don't belong in one-big-lump PR together!
In my humble opinion, each Example you submit (or modify) should be its own PR.
@leewardbound i am sorry, this PR was submitted my mistakes. i didn't realize this got submitted
No worries, I am sorry if I came off tough, hope the feedback was helpful 😊
yes. i submitted a new PR. that is genuine :) hope that helps
Description
Reference issue
Fixes #...