search

ionos-cloud / sdk-go

Apache License 2.0
7 stars 1 forks source link

IpBlocks.GetItems should return IpBlock Slice, not pointer to IpBlock Slice #21

Open Ntr0 opened 2 years ago

Ntr0 commented 2 years ago

The function's comment states that the zero value of []IpBlock should be returned if Items is nil. Why can't we then return a slice instead of a slice pointer?

https://github.com/ionos-cloud/sdk-go/blob/207dec5b5aec6512e821aaa9b402dd755d5a1f90/model_ip_blocks.go#L149

Ntr0 commented 2 years ago

I'd like to add that all Getters should not return pointers to something unless explicitly required, as this makes the sdk painful to use.

cristiGuranIonos commented 2 years ago

Thanks, makes sense, I think this would be a breaking change. We will prioritize appropriately.