ionos-cloud / sdk-python

Apache License 2.0
2 stars 3 forks source link

fix: parse proxy header envs correctly - fixes #15 #16

Open hegerdes opened 11 months ago

hegerdes commented 11 months ago

This fixes the bug reported in #15.

Is is a serious problem for us since we experiance sporadic but repeated proxy disconnects. The error message is when used via ansible:

"msg": "failed to create the new server: ('Unable to connect to proxy', RemoteDisconnected('Remote end closed connection without response'))"

The modification was tested without and with ansible

Closes #15

rmocanu-ionos commented 10 months ago

hello, we will add this to our templates and it will be included in the next release

hegerdes commented 10 months ago

@ionoscloudsdk You integrated my change without merging my PR or referencing me anywhere?

This shows very poor open source manners. It's effektiv stealing the code for that fix. There are numerous problems with the code and services that IONOS provides and they would be well-advised to appreciate any contribution but this is obviously not welcome. Not going to do anything again for you.

For reference: The code I provided was 100% copy pasted and is included in this commit 8d447d1

mimihalescu commented 10 months ago

Dear @hegerdes,

First and foremost, we sincerely apologize for the oversight in not acknowledging your contribution to our changelog. We greatly value the open-source community and contributions like yours, and it was never our intention to discredit your work or claim it as our own.

Your input was significant, and we included it in our latest release by integrating it into the OpenAPI Generator templates. Due to the automated nature of our SDKs, as mentioned in our documentation, direct PRs cannot be merged, and contributions are typically implemented in the generator itself. This process, unfortunately, led to your work being included without direct attribution, which was an error on our part.

We understand and share your concern for proper open-source etiquette and the importance of recognizing each contributor's efforts. Your feedback is a learning opportunity for us, and we are committed to improving our processes to ensure proper acknowledgment of all contributions in the future.

To rectify this, we will:

We appreciate your input and are committed to fostering a respectful and collaborative relationship with contributors like yourself. Thank you for your understanding!