search

ionos-cloud / terraform-provider-ionoscloud

The IonosCloud Terraform provider gives the ability to deploy and configure resources using the IonosCloud APIs.
Mozilla Public License 2.0
34 stars 23 forks source link

Build Fails #84

Closed mneverov closed 3 years ago

mneverov commented 3 years ago

Description

Build fails with 

➜  terraform-provider-ionoscloud git:(master) make build
==> Checking that code complies with gofmt requirements...
gofmt needs running on the following files:
./ionoscloud/data_source_k8s_cluster.go
You can use the command: `make fmt` to reformat code.
make: *** [GNUmakefile:32: fmtcheck] Error 1

After fixing formatting there are multiple errors:

➜  terraform-provider-ionoscloud git:(master) ✗ make build
==> Checking that code complies with gofmt requirements...
go install
ionoscloud/provider.go:6:2: cannot find package "." in:
        /home/mneverov/go/src/github.com/ionos-cloud/terraform-provider-ionoscloud/vendor/github.com/hashicorp/terraform-plugin-sdk/v2/diag
ionoscloud/provider.go:14:2: cannot find package "." in:
        /home/mneverov/go/src/github.com/ionos-cloud/terraform-provider-ionoscloud/vendor/github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource
ionoscloud/data_source_datacenter.go:9:2: cannot find package "." in:
        /home/mneverov/go/src/github.com/ionos-cloud/terraform-provider-ionoscloud/vendor/github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema
ionoscloud/data_source_k8s_node_pool.go:8:2: cannot find package "." in:
        /home/mneverov/go/src/github.com/ionos-cloud/terraform-provider-ionoscloud/vendor/github.com/hashicorp/terraform-plugin-sdk/v2/helper/validation
ionoscloud/config.go:5:2: cannot find package "." in:
        /home/mneverov/go/src/github.com/ionos-cloud/terraform-provider-ionoscloud/vendor/github.com/hashicorp/terraform-plugin-sdk/v2/meta
main.go:6:2: cannot find package "." in:
        /home/mneverov/go/src/github.com/ionos-cloud/terraform-provider-ionoscloud/vendor/github.com/hashicorp/terraform-plugin-sdk/v2/plugin
ionoscloud/config.go:6:2: cannot find package "." in:
        /home/mneverov/go/src/github.com/ionos-cloud/terraform-provider-ionoscloud/vendor/github.com/ionos-cloud/sdk-go/v5
ionoscloud/data_source_k8s_cluster.go:10:2: cannot find package "." in:
        /home/mneverov/go/src/github.com/ionos-cloud/terraform-provider-ionoscloud/vendor/gopkg.in/yaml.v3
make: *** [GNUmakefile:9: build] Error 1

Also, the Developing the Provider section mentions make bin, which should probably be replaced with make build.

Expected behavior

Build is successful.

Provider version: Latest master.

OS: Ubuntu 20.04

iblindu commented 3 years ago

@mneverov please check now the latest master

mneverov commented 3 years ago

@IuliaBlindu just updated to the latest master - it works, thanks