search

ionutbortis / gnome-bedtime-mode

Home of the "Bedtime Mode" :zzz: GNOME Shell Extension.
GNU General Public License v3.0
78 stars 12 forks source link

Version 6 Error on Shell 40.4.0 #16

Closed HackaN closed 3 years ago

HackaN commented 3 years ago

Installed via extensions.gnome.org, error message says "entry.get_child is not a function"

ionutbortis commented 3 years ago

Hello,

I tried unsuccessfully to replicate the issue on a Fedora 34 VM with Gnome 40.4.0...

Can you provide more details on the issue? Like running OS, which OS version? Are you running some gnome extensions that remove/alter the top right aggregated menu/panel?

This might be the problematic code, but it would be nice to figure out why it doesn't work on your setup: modules/Decorator.js:

const aggregateMenuFinder = (entry) => entry.get_child() === MainPanel.statusArea.aggregateMenu;
const aggregateMenuIndex = MainPanel._rightBox.get_children().findIndex(aggregateMenuFinder);

The code is trying to find the position of the aggregated menu in top bar, right box, and by default it tries to position the Bedtime Mode icon just before it. The numbered index positioning is not very reliable, after a restart some extensions will battle for the 0 index and you won't get the same position for your extension. This way, the Bedtime Mode icon will always sit just before the aggregated menu.

No tests were performed, so far, where the right box in top bar is fully cleared with no items to show. Is this the case?

HackaN commented 3 years ago

I get the same issue on both my machines (Fedora 34 Workstation and the other is Garuda Linux), both running Gnome 40.4.0. I did get the extension to work on a LiveCD of GeckoLinux earlier today... Could it perhaps be a Wayland related issue?

HackaN commented 3 years ago

It's not Wayland-related, just tried to log into Gnome with X and the same thing happens.

The active extensions on fedora are...

::: Manually installed :::

::: Built in :::

ionutbortis commented 3 years ago

I just created a fresh VM of Fedora 34 using Boxes, applied the updates and the Bedtime Mode extension works fine. I suspect there might be some interference with the way other extensions are changing the Gnome shell.

Are you having this menu on the right side in top bar? Screenshot from 2021-09-23 23-22-24

If not, how did you customize your shell?

Later edit: I installed all the above mentioned extensions on Fedora 34 (Workstation Edition), Gnome 40.4.0, and still no reproducible issue (you can see the Bedtime Mode [Zzz] icon added in the Top Bar).

Also for the Built-In list, my Fedora instance has these extensions:

HackaN commented 3 years ago

it seems like the problem might have been something with my fedora installation. The computer has panicked a few times and I boot up to a automatically restored desktop and when I enable the extensions again Bedtime Mode now seems to work.

ionutbortis commented 3 years ago

Closing since it can't be reproduced any more :tada: