Skips deployment of AWS networking-related resources for cases where existing subnet_id, vpc_id provided

ioos / Cloud-Sandbox

IOOS' Coastal Modeling Cloud Sandbox provides a framework for developing, modifying and running models in the cloud. It provides repeatable configurations, model code and required libraries, input data and analysis of model outputs. The Sandbox supports not only the development of services and models, but also Cloud HPC to run and validate models.

https://www-sandbox.ioos.us/

BSD 3-Clause "New" or "Revised" License

15 stars 12 forks source link

Skips deployment of AWS networking-related resources for cases where existing subnet_id, vpc_id provided #73

Closed mwengren closed 11 months ago

mwengren commented 11 months ago

This PR updates the working branch x86_64 with some minor networking changes to deploy into an existing VPC/Subnet with external networking components (as is present in the NOAA AWS environment).

This change assumes that if both a vpc_id and subnet_id are provided to the template as variables, then the networking components are already in place outside of Terraform to enable communication. In this situation, the head node will not automatically be assigned an EIP, an Internet Gateway is not created, and a Route Table and Route Table Association are skipped as well.

patrick-tripp commented 11 months ago

Micah, The changes work fine on my deployment into a new VPC.

Patrick

mwengren commented 11 months ago

Thanks @patrick-tripp. These changes should be pretty straightforward, I'll go ahead and merge.

The x86_64 branch I was working from didn't include some of the recent commits by @ZacharyWills to comment out the networking sections, which I don't think we need with these changes anyway. If merging this PR doesn't remove those, they may need to be removed manually by another commit.