The TransactionSolidifier has a set value of 50k transactions for analyzed hashes as legacy from the previous milestone logic. With high tps environments it's possible for this low threshold to be reached between milestones and slow or stall out synchronisation. To accommodate this the max value should be increased to 300k minimum to account for the possibility of a 1000TPS environment with a 30 second tick rate for compass.
Type of change
Enhancement (a non-breaking change which adds functionality)
How the change has been tested
Less false returns for solidification as a result of the maximum capacity of analyzed transactions being reached.
Change checklist
[x] My code follows the contribution guidelines for this project
[x] I have performed a self-review of my own code
[x] New and existing unit tests pass locally with my changes
Description of change
The
TransactionSolidifierhas a set value of 50k transactions for analyzed hashes as legacy from the previous milestone logic. With high tps environments it's possible for this low threshold to be reached between milestones and slow or stall out synchronisation. To accommodate this the max value should be increased to 300k minimum to account for the possibility of a 1000TPS environment with a 30 second tick rate for compass.Type of change
How the change has been tested
Less false returns for solidification as a result of the maximum capacity of analyzed transactions being reached.
Change checklist