iotexproject / iotex-core

Official implementation of IoTeX blockchain protocol in Go. An ultra-efficient EVM blockchain offering 1000 TPS with instant 1-block finality. Perfect for DeFi, DePIN tokenomics, Identities, and any trusted logic requiring Web3 composability
https://iotex.io
Apache License 2.0
1.55k stars 324 forks source link

add blockdao server and grpc blockdao #4263

Open CoderZhi opened 4 months ago

CoderZhi commented 4 months ago

Add grpc blockdao, which will request blockdao server to read data remotely

Follow up PR needed to setup a sever to serve blockdao (including building)

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Test Configuration:

Checklist:

dustinxie commented 4 months ago

add a flag in config, to selectively start this grpc blockdao service when starting the node?

Liuhaai commented 4 months ago

The aim seems to setup a side server to serve blockdao directly. The code would be better to be added in ./server or ./tools package.

sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed

Issues
29 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov[bot] commented 4 weeks ago

Codecov Report

Attention: Patch coverage is 3.34928% with 202 lines in your changes missing coverage. Please review.

Project coverage is 74.82%. Comparing base (36f0d99) to head (8de28fe). Report is 16 commits behind head on master.

Files with missing lines Patch % Lines
blockchain/blockdao/grpcblockdao.go 0.00% 127 Missing :warning:
api/blockdaoservice.go 3.84% 75 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4263 +/- ## ========================================== - Coverage 75.86% 74.82% -1.04% ========================================== Files 361 368 +7 Lines 30116 30501 +385 ========================================== - Hits 22846 22823 -23 - Misses 6134 6519 +385 - Partials 1136 1159 +23 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 2 weeks ago

Quality Gate Passed Quality Gate passed

Issues
28 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud