[staking] ReadState API support Candidate ID

[envestcc]

Description

Due to the introduction of a new ID as a unique identifier by the Candidate, the following modifications need to be made to the API:

• Upgrade the candidateByAddress, candidateByName, and candidates APIs to v3, adding 'id' to the returned results.
• Add a new API called candidateByID; the original meaning of the candidateByAddress is to query based on the owner's address.

It's based on https://github.com/iotexproject/iotex-proto/pull/151

Type of change

Please delete options that are not relevant.

• [x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• [] make test
• [] fullsync
• [] Other test (please specify)

Test Configuration:

• Firmware version:
• Hardware:
• Toolchain:
• SDK:

Checklist:

• [] My code follows the style guidelines of this project
• [] I have performed a self-review of my code
• [] I have commented my code, particularly in hard-to-understand areas
• [] I have made corresponding changes to the documentation
• [] My changes generate no new warnings
• [] I have added tests that prove my fix is effective or that my feature works
• [] New and existing unit tests pass locally with my changes
• [] Any dependent changes have been merged and published in downstream modules

[dustinxie]

can you rebase this PR? i think lots of code has already checked in

[CoderZhi]

As discussed offline, let's change the logic of creating delegate to:

if delegateByOwner(creator) != nil {
    return duplicate error
}
id := creator
while delegateByIdentifier(id) != nil { // up to N = 1000 times
    id = hash(id)
}
create delegate with id

such that an account who doesn't own a delegate could always create a delegate.

Make sure the scenario works in this PR.

[dustinxie]

Member

As discussed offline, let's change the logic of creating delegate to:

if delegateByOwner(creator) != nil {
    return duplicate error
}
id := creator
while delegateByIdentifier(id) != nil { // up to N = 1000 times
    id = hash(id)
}
create delegate with id

such that an account who doesn't own a delegate could always create a delegate.

Make sure the scenario works in this PR.

agreed, discussed offline we can use logic similar to id = hash(address, blockheight)

[sonarcloud[bot]]

Quality Gate failed

Failed conditions
24.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud