envestcc commented 3 months ago

Description

The pr introduce e2etest framework to simplify add test cases, focusing on construct actions and expectations. Futhermore, add testcases via the frameworks for original action handlings after candidate ownership transfer.

based on #4294

Type of change

Please delete options that are not relevant.

[x] Code refactor or improvement

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[] make test
[] fullsync
[] Other test (please specify)

Test Configuration:

Firmware version:
Hardware:
Toolchain:
SDK:

Checklist:

[] My code follows the style guidelines of this project
[] I have performed a self-review of my code
[] I have commented my code, particularly in hard-to-understand areas
[] I have made corresponding changes to the documentation
[] My changes generate no new warnings
[] I have added tests that prove my fix is effective or that my feature works
[] New and existing unit tests pass locally with my changes
[] Any dependent changes have been merged and published in downstream modules

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 47.94521% with 38 lines in your changes missing coverage. Please review.

Project coverage is 76.69%. Comparing base (cc526cd) to head (b63aadf). Report is 31 commits behind head on master.

:exclamation: Current head b63aadf differs from pull request most recent head 991bbab

Please upload reports for the commit 991bbab to get more accurate results.

Files	Patch %	Lines
action/signedaction.go	50.00%	24 Missing and 11 partials :warning:
action/protocol/staking/protocol.go	0.00%	3 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #4295 +/- ## ========================================== - Coverage 77.02% 76.69% -0.34% ========================================== Files 342 352 +10 Lines 29406 29310 -96 ========================================== - Hits 22651 22479 -172 - Misses 5650 5727 +77 + Partials 1105 1104 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 3 months ago

Quality Gate failed

Failed conditions
5.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

iotexproject / iotex-core

[e2etest] add tests for original actions after candidate ownership transfer #4295