search

ip7z / 7zip

7-Zip
458 stars 57 forks source link

[Bug] Language text file uses Unix CR line ending #14

Open PopuriAO29 opened 5 months ago

PopuriAO29 commented 5 months ago

Describe the bug If you try open notepad (such as Windows Notepad) running on Windows 2000 through Windows 7, the line ending is incorrect for Language text files.

To Reproduce

Steps to reproduce behavior:

  1. Open the directory following these: C:\Program Files\7-Zip 1.1: If you are running 64-bit but with 32-bit installed, find here: C:\Program Files (x86)\7-zip
  2. Double click the Lang folder.
  3. Click the text files anything you want, such as fr.txt and de.txt
  4. See the line ending that is incorrect.

Expected behavior Line Ending must set DOS/Windows that allowing CR and LF (according on MousePad xfce)

Screenshots Here is the comparison Before and After. 7zip-FrenchLanguage-LineEndingCompare

The Before shows Unix Line Ending which there are lots of square symbol, meaning it is glitched if you run Windows Notepad. In Windows 10 v1809, it only works fine.

The after: This is the Line ending that I changed from Unix to DOS/Windows itself.

What version(s) of 7-Zip have this bug? 24.01 Beta x86 according below in environment and others.

Environment and others (please complete the following information)

Additional Context Line Ending for translation might glitched if you save again when you running on Windows, resulting error message appears (well, sort of). However, the issue was found back in version 24.01 released. In that circumstance, 23.01 is okay, since the Line ending had DOS/Windows itself.

However, the solution is simple, you can use Notepad2 by following select: File -> Line Endings -> Windows (CR+LF). For Notepad++, there is line ending option called EOL Conversion.

Have you checked that no similar bug report(s) exist?

ip7z commented 5 months ago

It's not bug. The files are smaller if we use LF only instead of CR_LF pair. And the loading can be slightly faster also. So we get smaller size of whole installer and smaller size of installed files. Usual users don't need to open LANG files in text editor. Only translators open them. And I supposed that translators can work with LF files, because latest Windows versions support them.

PopuriAO29 commented 5 months ago

Windows version depends if running Notepad, such as 5.1.2600, obviously the line ending might glitched itself, including square.

In Windows 10 v1809, it works fine, prior previous Windows version such as 7 through 2000, that explains called bug. I've tried to modify it and I check the options for some reason.

It's simple solution, using Notepad2 or Notepad++ will resolve the issue.