ipa320 / schunk_modular_robotics

www.schunk-modular-robotics.com
Apache License 2.0
56 stars 94 forks source link

fix lwa4d urdf - joint orientation according to convention #148

Closed fmessmer closed 9 years ago

fmessmer commented 9 years ago
ipa-nhg commented 9 years ago

This pull request should be tested on a cob3, or at least communicate the cob3 developers that they should not update their repository before check with MTS the motor orientations.

fmessmer commented 9 years ago

This PR only affects cob3-9, In simulation it looks like this: cob3-9_gazebo cob3-9

Seems like the mounting position of the arm needs to be adjusted: https://github.com/ipa320/cob_robots/blob/indigo_dev/cob_hardware_config/cob3-9/urdf/calibration_default.urdf.xacro#L58-L63

Also, the default_arm_configs need to be checked: https://github.com/ipa320/cob_robots/blob/indigo_dev/cob_default_robot_config/cob3-9/arm_joint_configurations.yaml

ipa-nhg commented 9 years ago

Updated and tested on cob3-9. Please merge together with this pull request the cob_robots changes: https://github.com/ipa320/cob_robots/pull/343

floweisshardt commented 9 years ago

LGTM