ipatix / gba-hq-mixer

This repository contains multiple versions of my so called "HQ mixer" for GBA games which use the m4a/mp2k sound driver.
GNU General Public License v3.0
36 stars 6 forks source link

Game Crash #5

Closed Skeli789 closed 3 years ago

Skeli789 commented 3 years ago

Environment

Visual Boy Advance-M 2.1.1

Details

I tested this thoroughly using both the old sound engine (2.1) and the current engine (4.0). The following crash only happens with v4.0 both with and without the changes suggested here (the following video example is using the original code in the repo).

https://user-images.githubusercontent.com/17243618/119367621-22c36a80-bc80-11eb-8c2c-f10d19a1bc87.mp4

The disassembler shows an infinite increase now:

image

Additional Details

If it helps, the hq_buffer_ptr constant was set to 0x30028E0.

ipatix commented 3 years ago

This occurs due to corruption of DMA registers.

If you do binary hacking, change ENABLE_DMA to 0. If you do decomp modding, make the DMA transfers atomic. Check this for instructions on how to do it: https://github.com/pret/pokeemerald/wiki/Implementing-ipatix%27s-High-Quality-Audio-Mixer