ipbus / ipbus-firmware

Firmware that implements a reliable high-performance control link for particle physics electronics, based on the IPbus protocol
https://ipbus.web.cern.ch
Other
41 stars 32 forks source link

Fix Ipbus issue 136 #138

Closed jhegeman closed 4 years ago

tswilliams commented 4 years ago

Thanks for creating this pull request! I just have one small request: Can you change lines 27 to 38 of the new file from ...


src ipbus_transport_axi_if.vhd

src ipbus_transport_ram_if.vhd ipbus_transport_ram_if_simtb.vhd
src ipbus_transport_multibuffer_if.vhd
src ipbus_transport_multibuffer_cdc.vhd
src ipbus_transport_multibuffer_rx_dpram.vhd ipbus_transport_multibuffer_tx_dpram.vhd

src ipbus_axi_decl.vhd

?toolset=="Vivado"? src ../cgn/axi_bram_ctrl_0.xci

include -c components/ipbus_core 

... to ...

src ipbus_transport_ram_if_simtb.vhd
include ipbus_transport_axi.dep
jhegeman commented 4 years ago

Good point. Too much copy-paste involved in the original version. Fixed.

tswilliams commented 4 years ago

Run tests, please

tswilliams commented 4 years ago

(@jhegeman Previous message can be ignored - it just initiates the automated builds)