search

ipeaGIT / gtfs2gps

Convert GTFS data into a data.table with GPS-like records in R
https://ipeagit.github.io/gtfs2gps/
Other
71 stars 10 forks source link

st_make_valid moves to sf #112

Closed edzer closed 4 years ago

edzer commented 4 years ago

Upcoming lwgeom no longer exports st_make_valid, but sf does. This will affect CRAN checks of gtfs2gps with

Error: object ‘st_make_valid’ is not exported by 'namespace:lwgeom'
Execution halted
ERROR: lazy loading failed for package ‘gtfs2gps’

Please fix and submit to CRAN.

rafapereirabr commented 4 years ago

Thank you for the heads up, @edzer . @pedro-andrade-inpe , I checked our package code and it seems we are not using st_make_valid in any specific operation. So perhaps we can drop @importFrom lwgeom st_make_valid in the zzz.R script. Correct?

pedro-andrade-inpe commented 4 years ago

Thanks, @edzer. @rafapereirabr, we do not use st_make_valid, but we need lwgeom, otherwise we get the following error in the tests:

Converting shapes to sf objects
   Error in sf::st_length(geometry) : 
     package lwgeom required, please install it first

As we need lwgeom, we have to import at least one function from it to avoid check errors. I'll just replace st_make_valid by st_geod_length, which is the function called by sf::st_length().

rafapereirabr commented 4 years ago

Thanks for the clarification. I guess we can close this issue then.