search

iperov / DeepFaceLive

Real-time face swap for PC streaming or video calls
GNU General Public License v3.0
26.92k stars 58 forks source link

Docker-build #141

Closed valador closed 1 year ago

valador commented 1 year ago

Some fixes for work on docker.

iperov commented 1 year ago

@CeeBeeEh check it please

iperov commented 1 year ago

@CeeBeeEh ?

CeeBeeEh commented 1 year ago

@iperov looks good at first glance, I haven't had a chance to test it yet. (sorry about the first message, I didn't get any notifications for it)

@valador just wondering, on lines 4,5 of the Dockerfile, wouldn't it make more sense to set the container's UID to be the same as the UID of the user launching the container? That way you would avoid any permission issues. For example, if my host UID is 1001 and I link to a data folder in my home directory, then the container's UID of 1000 would not be able to read the data.

valador commented 1 year ago

Yes, that's right, my user UID is 1000 when building a container, you can pass any UID, but you need to add detect user uid for build to start.sh and pass argument. I'll do it one of these days.

CeeBeeEh commented 1 year ago

@valador A simple id -u for the user ID and id -g for the group ID is all you need.

iperov commented 1 year ago

please do something or close

iperov commented 1 year ago

1 week and I will close this pr.