search

ipfs-inactive / dev-team-enablement

[ARCHIVED] Dev Team Enablement Working Group
3 stars 1 forks source link

Gx "go get" does not work in windows #137

Open hsanjuan opened 6 years ago

hsanjuan commented 6 years ago

Which Project is this about?

Go pipeline

Provide a link to a example run where it went wrong

https://ci.ipfs.team/blue/organizations/jenkins/IPFS%2Fipfs-cluster/detail/fix%2Fupdate-go-dot/2/pipeline/10

Which platform did the issue happen on?

Windows

The pipeline should not be "go get"ing Gx, it should download the pre-compiled version.

[ipfs-cluster] Running batch script

c:\jenkins\workspace\s-cluster_fix_update-go-dot-L6V2S7PHIO2KJQKP7Q6V7DI574M47SRGMUFQCBZSFE3L7VNXK5XA\src\github.com\ipfs\ipfs-cluster>go get -v github.com/whyrusleeping/gx 

github.com/ipfs/go-log

# github.com/ipfs/go-log

..\go-log\oldlog.go:75:16: undefined: logging.NewSyslogBackend

script returned exit code 2
daviddias commented 5 years ago

Should this be an issue with gx itself? Summoning our Windows master, @djdv \o/

djdv commented 5 years ago

Sorry for the delay, I missed this notification. So on my current TODO list is to investigate this further: https://github.com/ipfs/go-ipfs/pull/5224

A lot of my early contributions where around building and testing on Windows, and go-ipfs seems to be alright in those regards today. However, our CI environment is setup in a way that I'm not familiar with and is causing some issues. It also doesn't use a configuration similar to the Windows build documentation, of which there are several common supported environments.

I need to figure out what our CIs are expected to handle, and what dependencies those have. I'm guessing they really only need to be able to reliably build and run go-ipfs itself + test it, and js-ipfs itself +tests for it. But I'd appreciate any guidance/insight here. This may or may not be complicated depending on requirements and proposed solutions, but I'm in the dark on those right now.

I'm very familiar with setting up a Windows test/dev environment for go-ipfs, as well as what's needed to automate all of it, but I can't say the same for js-ipfs or even Jenkins itself.