Jenkinsfile should always be fetched from master - Githubissues

ipfs-inactive / jenkins

[ARCHIVED] Configuration for IPFS's build system

https://ci.ipfs.team/blue

8 stars 6 forks source link

Jenkinsfile should always be fetched from master #18

Closed victorb closed 7 years ago

victorb commented 7 years ago

In case someone makes a bad PR with changes to the Jenkinsfile, like dumping our credentials or such, we'd like to always use the Jenkinsfile from master.

However, there are cases where changes to Jenkinsfile should be allowed, so we should have a way of overriding this as well, if you have the right permissions.

Acceptance Criteria

[x] When anyone makes a PR, Jenkins uses the Jenkinsfile from master instead from PR
[x] When a trusted user makes a PR, Jenkins uses the Jenkinsfile from the branch of the PR

Tasks

victorb commented 7 years ago

Doesn't use Jenkinsfile from master but rather from jenkins itself.