ipfs-rust / ipfs-embed

A small embeddable ipfs implementation
352 stars 48 forks source link

support for gossipsub #18

Closed ghost closed 3 years ago

ghost commented 3 years ago

Is any support for publish/subscribe planned? At the moment it looks like this wouldn't be possible without forking the crate.

dvc94ch commented 3 years ago

I'll be adding a network trait soon that will allow you to do your own networking. Does that help? Pubsub is not really required for ipfs, so it's not enabled.

dvc94ch commented 3 years ago

Added network trait, closing.

dvc94ch commented 3 years ago

I changed my mind on this feature. It only requires providing two additional functions publish and subscribe, I think we can have them in ipfs-embed.

cryptoquick commented 3 years ago

That'd be perfect, @dvc94ch, since I do have pub/sub planned, but it's also nice that you expose the network traits. I assume that allows us to hook into libp2p and, say, allow nodes to communicate with other nodes directly?

dvc94ch commented 3 years ago

Opened a wip pr for this here #32. If someone is interested in finishing it, it needs at least one passing test. I'm not too bothered about it right now

dvc94ch commented 3 years ago

Closed by #31