search

ipfs / distributions

Legacy dist.ipfs.tech website and artifact build tools. Currently only used for notarizing builds of Kubo and IPFS Cluster.
https://dist.ipfs.tech
MIT License
47 stars 32 forks source link

fix: do not include full path to binary in .sha512 files #1108

Closed hsanjuan closed 3 weeks ago

hsanjuan commented 3 weeks ago

See https://github.com/ipfs/kubo/issues/9323.

This is a darwin release thing because the signature process for macOS means that we recalculate sha512 and cid and we do this using an absolute path so the result includes the path to the file.

The fix is to cd to the folder and do it from there.

github-actions[bot] commented 3 weeks ago

This change produced no new differences in built artifacts.

lidel commented 3 weeks ago

Thanks!

I'll try to test.

Manually dispatched https://github.com/ipfs/distributions/actions/workflows/main.yml with branch set to fix/kubo-9323 (this PR) and DIST_ROOT set to /ipfs/QmeqkkydCxmREqg2qmoA7XQSYbcgvSko5zDAhnarKFp2Ki (version without 0.32.0-rc2, so we have actual build happening) to see if produced DAG has expected values, but it did not work the way I expected.

Update: we had a bug (https://github.com/ipfs/distributions/pull/1108/commits/116dfe2e2659436791b019b4fbb4f8e3d45aa79e), will fix and retry.

Update: 0.32.0-rc2 builds, let's wait until this CI run is done.